LaTeX rendering ignores escaped dollar signs

ReviewNB / support

Issues and feature requests for ReviewNB

https://reviewnb.com

58 stars 8 forks source link

LaTeX rendering ignores escaped dollar signs #41

Closed sid-kap closed 5 years ago

sid-kap commented 5 years ago

Including \$ in a Markdown cell should escape the dollar sign and prevent Latex from being rendered. Instead, latex is being rendered regardless, so a lot of random text appears as latex when it should not

amit1rrr commented 5 years ago

@sid-kap Thanks for reporting.

I reproduced this issue below and it's indeed a problem. We'll deploy a fix for this next week. Looks like you are from Affirm Inc who are using on-prem version of ReviewNB. So I'll create an update for you to pick up as well.

Actual change in Notebook -

Our diff screwed it up -

amit1rrr commented 5 years ago

@sid-kap The fix is deployed on app.reviewnb.com (see screenshot).

Going to close this issue now. I will inform you once we push out an on-prem update to be picked up by Affirm's technical team. Thanks again for reporting the issue.

Also, please note, you should use 2 slashes before $ sign to properly escape the $ symbol in Jupyter (Reference). A single \ before $ sign still enters the math mode in Jupyter UI.

Screenshot 2019-09-09 at 6 23 05 PM

sid-kap commented 5 years ago

Thanks for addressing this so quickly!

amit1rrr commented 5 years ago

@sid-kap You're welcome. We also just pushed an update to Affirm's on-prem version and have notified your technical team for update. Matt Leonard is our point of contact if you wish to know when the fix would be rolled out to you.

Also, I'd love to get your feedback on ReviewNB usage and some upcoming features. If you'd like to opt into some friendly feedback, please write to me at amit@reviewnb.com (sorry, we don't have your email on file).

sid-kap commented 5 years ago

Sure! I've only been using ReviewNB for a week or so, but I have some ideas/feature requests that I could write up and send you when I get the time