search

ReviewNB / support

Issues and feature requests for ReviewNB
https://reviewnb.com
58 stars 8 forks source link

Some missing plotly cell outputs #49

Closed cfoisy-osisoft closed 4 years ago

cfoisy-osisoft commented 4 years ago

Not sure why (different version of plotly?) but most of our plotly graphs show correctly in the side-by-side diff, while for some we get: image

Source URL: https://app.reviewnb.com/cfoisy-osisoft/academic-hub/pull/7/files/

amit1rrr commented 4 years ago

@cfoisy-osisoft Thank you for reporting. There was an issue where plotly graphs wouldn't render when there are multiple outputs. I have pushed a fix & now it should work fine.

Please let me know if you see any more problems.

cfoisy-osisoft commented 4 years ago

@amit1rrr Thanks for the quick fix. Now all plots are showing, but unfortunately many of them have a duplicate shown at a different scale, e.g.:

image

amit1rrr commented 4 years ago

many of them have a duplicate shown at a different scale

@cfoisy-osisoft Actually these are not duplicates. One is a PNG image output & the other is plotly's HTML output. You can test it by hovering over the image (nothing happens) and the HTML (you'll see plotly's controls).

The previous version of the file (left hand side of the diff) has both image & HTML outputs hence they are rendered one after the other.