search

ReviewNB / support

Issues and feature requests for ReviewNB
https://reviewnb.com
59 stars 8 forks source link

ReviewNB Bot functionality #53

Closed merrcury closed 4 years ago

merrcury commented 4 years ago

I have noticed weird behaviour of ReviewNB Bot, recently.

This behaviour can be seen in tensorflow/gan. I'm just curious to know. :wink:

amit1rrr commented 4 years ago

@merrcury Thank you for opening the issue. Good to know that you care about bot comments and find them useful :)

There are primarily 2 reasons for absent bot comments (both tied to GitHub outages),

  1. GitHub not sending us a webhook that the PR is opened.
  2. GitHub API is failing to accept bot comments

I looked at tensorflow/gan PRs and there's only one PR (#20) that is missing bot link. I looked into our logs and we never received GitHub webhook for this pull request. Looks like this PR was opened when this incident was going on at GitHub on 27th Feb 2020.

There's no easy workaround if GitHub doesn't send us notifications that a pull request is opened. I also assume (and expect) GitHub to resend missed webhooks after recovery. Maybe that is not happening today. If I see more issues like this, I'll talk to the GitHub team about this.

merrcury commented 4 years ago

That makes sense. I'll keep an eye about such behaviour in future as well & will report to you if it happens too frequently. Btw, We love ReviewNB.

markusbkoch commented 4 years ago

@amit1rrr thanks for the awesome product. I assume the bots don't show up in this PR because it was opened before we gave ReviewNB access to the repo? Is there a way to flag it so that the bot becomes aware of it?

amit1rrr commented 4 years ago

@markusbkoch Yes, we start posting bot comments on PRs created after ReviewNB app is installed on the repo. Technically, it is possible to backfill all past PRs but it would generate a lot of email notifications for people watching these repositories who might consider this a spam as most of them might not even know about ReviewNB (considering this is a new installation).

Couple of things to solve your problem though -

  1. ReviewNB URL format for PR, commit, repo are all identical to GitHub URL format. That means, if you are on GitHub PR page then just changing the URL from github.com to app.reviewnb.com should take you to corresponding page.
  2. You can even create a dynamic bookmark to quickly jump from GitHub to ReviewNB and vice a versa.