Support for GitLab #6

Open amit1rrr opened 6 years ago

Extend ReviewNB to be used with GitLab

Feel free to upvote/downvote the issue indicating whether you think this is useful feature or not. I also welcome additional questions/comments/discussion on the issue.

+1 if you could support Gitlab (in premise, not only gitlab.org).

any update on this?

@dwy904 Sorry, I do not have any updates on this at the moment. I will definitely update this issue once I have something concrete to share.

+1

+1 !!

+1

Any updates on this? Would love this feature for our organisation! Currently this stops us from using ReviewNB.

We did an API compatibility test for building GitLab integration of ReviewNB. There are couple of blockers in the GitLab API & we've opened/tracking the following issues with them,

Patch size limit in commit API [BLOCKER]
access_raw_diffs not working in PR API [BLOCKER]
OAuth apps should be able to post bot comments [BLOCKER]
Limit OAuth Scope to select repositories

We're working with GitLab ecosystem & code review team to get these resolved but I'm not sure if & when they'll be able to unblock us. Feel free to jump on these issues for upvote/workarounds etc.

UPDATE

Based on the response from GitLab team (here & here), it does not look like they've any plans to make API changes. This means nobody can fetch full PR/commit patch from GitLab. So third party apps (like ReviewNB) cannot build better code review experience for GitLab.

If notebook code review is important for you, consider moving your repositories to GitHub or BitBucket.

+1

ReviewNB / support

Support for GitLab #6

UPDATE