Resolved conversations not reflected on Github

ReviewNB / support

Issues and feature requests for ReviewNB

https://reviewnb.com

58 stars 8 forks source link

Resolved conversations not reflected on Github #66

Closed JoyZW closed 4 years ago

JoyZW commented 4 years ago

Currently when comments are marked as 'resolved' in ReviewNB, the status change is not reflected on Github.

amit1rrr commented 4 years ago

It's because GitHub does not yet have an API to mark comment threads resolved or unresolved (API docs). If & when this API is introduced we'd update conversation status on GitHub side as well.

P.S. - Currently pull request conversation comments have an invisible div tag that stores status=open|resolved so in effect the status is still available on GitHub side, it's just that the threads are not officially marked as resolved|open due to lack of GitHub API support.