search

ReviewNB / support

Issues and feature requests for ReviewNB
https://reviewnb.com
58 stars 8 forks source link

Provide an option to make reviews of public notebooks public #75

Closed Daniel-Mietchen closed 3 years ago

Daniel-Mietchen commented 3 years ago

This is especially important since it currently does not seem to be possible to use ReviewNB to review notebooks in repos owned by someone else.

amit1rrr commented 3 years ago

Are you asking to make reviews public in that they should be available to view without any login? Or are you requesting a feature where one should be able to review any public repository?

Daniel-Mietchen commented 3 years ago

@amit1rrr I would like both of these options, but this ticket was specifically about the former, since the latter can be approximated by forking the repo to be reviewed, and running ReviewNB on that (just as I did in my test).

amit1rrr commented 3 years ago

Showing public reviews/commits/PRs is not possible due to GitHub API limitations. When we make calls to GitHub to fetch this content we make the call on behalf of the logged in user (with user's access token). Without this token we'd quickly run into GitHub's API rate limits and won't be able to fetch the content.