search

ReviewNB / support

Issues and feature requests for ReviewNB
https://reviewnb.com
58 stars 8 forks source link

ReviewNB renders notebook incorrectly #88

Closed ivanmkc closed 3 years ago

ivanmkc commented 3 years ago

See https://github.com/GoogleCloudPlatform/ai-platform-samples/pull/281/files.

The following source:

"source": 

[
        "## Before you begin\n",
        "\n",
        "### Select a GPU runtime\n",
        "\n",
        "**Make sure you're running this notebook in a GPU runtime if you have that option. In Colab, select \"Runtime --> Change runtime type > GPU\"**\n",
        "\n",
        "### Set up your Google Cloud project\n",
        "\n",
        "**The following steps are required, regardless of your notebook environment.**\n",
        "\n",
        "1. [Select or create a Google Cloud project](https://console.cloud.google.com/cloud-resource-manager). When you first create an account, you get a $300 free credit towards your compute/storage costs.\n",
        "\n",
        "2. [Make sure that billing is enabled for your project](https://cloud.google.com/billing/docs/how-to/modify-project).\n",
        "\n",
        "3. [Enable the AI Platform (Unified) API and Compute Engine API](https://console.cloud.google.com/flows/enableapi?apiid=aiplatform.googleapis.com,compute_component).\n",
        "\n",
        "4. If you are running this notebook locally, you will need to install the [Cloud SDK](https://cloud.google.com/sdk).\n",
        "\n",
        "5. Enter your project ID in the cell below. Then run the cell to make sure the\n",
        "Cloud SDK uses the right project for all the commands in this notebook.\n",
        "\n",
        "**Note**: Jupyter runs lines prefixed with `!` as shell commands, and it interpolates Python variables prefixed with `$` into these commands."
      ]

is rendered incorrectly as:

Screen Shot 2021-04-19 at 6 38 05 PM
ivanmkc commented 3 years ago

Seems like something about the backtick causes a rendering problem.

amit1rrr commented 3 years ago

@ivanmkc Thanks for reporting. It was indeed an issue / edge case happening with some combination of dollor signs (mathjax) and backticks. We've deployed a fix for this.

Closing. Feel free to reopen if you see any more issues. Thanks again for bringing this to our attention :)

ivanmkc commented 3 years ago

Great turnaround time! Thanks for the stellar tool.