search

Reviewable / appengine-remove-action

Action to remove versions of deployed App Engine apps over the set limit
3 stars 2 forks source link

Slice bug removing versions even though below the limit #3

Closed Miyagee closed 3 years ago

Miyagee commented 3 years ago

I believe this should fix the slice bug. It checks the length and the limit before slicing the array. If the versions length is below the limit it ends the action. If it is above the limit it slices the versions array. Then the versionsToDelete will always have a minimum of 1 entry if it passes the length check.

pkaminski commented 3 years ago

Thanks! Merged and released as v2.1.1.