Reviewable / appengine-remove-action

Action to remove versions of deployed App Engine apps over the set limit
3 stars 2 forks source link

Usage example still refers to v2 specifically #4

Closed coolstuff-michael closed 2 years ago

coolstuff-michael commented 2 years ago

Slight issue I came across was that the version in the documentation is specifically set at v2 (uses: Reviewable/appengine-remove-action@v2). This was a little problematic for me as the fix for service_name was added in v2.1.1

pkaminski commented 2 years ago

Yeah, I always forget that action versions are baked right into the workflow files. Fixed.

coolstuff-michael commented 2 years ago

@pkaminski Same thing again for v2.1.2 :smile:

pkaminski commented 2 years ago

Argh, I updated the example but forgot to push.