Revivius / nb-darcula

Darcula LAF for NetBeans
277 stars 83 forks source link

Autocomplete of custom HTML elements are hard to read #106

Closed TobiasKrahn closed 8 years ago

TobiasKrahn commented 8 years ago

Maybe just another hardcoded color. ac

markiewb commented 8 years ago

Provide sample code for reproduction! I do not know, which filetype is it!

Revivius commented 8 years ago

@TobiasKrahn is this for Angular Material ?

TobiasKrahn commented 8 years ago

@markiewb It's just a html file. You should be able to reproduce it like this:

  1. Create a html project
  2. Enter some tags, that doesn't exist
  3. Click on the warning
  4. Click add to project custom Elements
  5. Use the added tag again with autocomplete

Sorry, that I can't provide any example. I'm currently on vacation :-).

@Revivius Yes, its angularjs or more specifically Angular Material element directives.

Revivius commented 8 years ago

@TobiasKrahn, @markiewb same problem: https://netbeans.org/bugzilla/show_bug.cgi?id=257867. We need more votes for that bug.

In the meantime fixed with reflection, will be available in v1.6.

Chris2011 commented 7 years ago

I have the same problem with this plugin: https://github.com/hexaviewtech/ionic-netbeans-plugin

Here is the screenshot: ionic-code-completion

Revivius commented 7 years ago

@Chris2011; as you might already know: code completion item colors are provided by the author of respective module/plugin. We have been replacing hardcoded colors in standard modules (such as SQL editor, HTML editor, etc) using reflection but it is not feasible to hack every single CompletionItem implementation. Module authors should check UIManager.getBoolean("nb.dark.theme") (assuming all dark look and feels set this to true as nb-darcula does) and provide alternate colors that are reasonably readable on a dark background.

In this specific case: it is this line causing hard to read color:

https://github.com/hexaviewtech/ionic-netbeans-plugin/blob/master/src/com/hexaview/ionicextension/IonicTagCompletionItem.java#L38

Please report the issue to ionic-netbeans-plugin.

Chris2011 commented 7 years ago

Thx for the explanation. I only thought because you fixed it for the above Plugin it was fixed in General.