search

Revivius / nb-darcula

Darcula LAF for NetBeans
277 stars 83 forks source link

Make Darcula work on Netbeans under JDK 9. #137

Closed twolf2919 closed 7 years ago

twolf2919 commented 7 years ago

The Darcula plugin causes a ClassNotFoundException when Netbeans is running on an EA version of JDK 9. It appears to be making use of class sun.swing.SwingLazyValue which I think is no longer part of the JDK.

Strictly speaking, this is not a bug report - JDK 9 isn't even out yet, but I figure I'll make the request because JDK 9 will be out fairly soon.

markiewb commented 7 years ago

See PR https://github.com/Revivius/nb-darcula/pull/136

Den 28 mars 2017 15:31 skrev "twolf2919" notifications@github.com:

The Darcula plugin causes a ClassNotFoundException when Netbeans is running on an EA version of JDK 9. It appears to be making use of class sun.swing.SwingLazyValue which I think is no longer part of the JDK.

Strictly speaking, this is not a bug report - JDK 9 isn't even out yet, but I figure I'll make the request because JDK 9 will be out fairly soon.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Revivius/nb-darcula/issues/137, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxWR82J5G2nL2kOhLDsuZFkWiJmk4lWks5rqQvBgaJpZM4Mrn7T .

Rahul-khandelwal commented 7 years ago

@Revivius @markiewb , Can we have a release of nb-darcula plugin with this fix. Many people are using netbeans with jdk-9 EA builds and whenever we start NB, we see this exception and it is also affecting other UI components like project's subtree and code completion suggestions. Thanks.

markiewb commented 7 years ago

I am not the owner/maintainer of this plugin.

We could fork the plugin, apply the PR and other pending PRs and publish it. But this won't be me! Anyone who wants to step in?

Den 31 mars 2017 06:57 skrev "Rahul-khandelwal" notifications@github.com:

@Revivius https://github.com/Revivius @markiewb https://github.com/markiewb , Can we have a release of nb-darcula plugin with this fix. Many people including me are using netbeans with jdk-9 EA builds and whenever we start NB, we see this exception and it is also affecting other UI components like project's subtree and code completion suggestions. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Revivius/nb-darcula/issues/137#issuecomment-290616035, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxWR39FUcmIyv4EEAjqY2wTeyt0Syu_ks5rrIfTgaJpZM4Mrn7T .

Rahul-khandelwal commented 7 years ago

@markiewb @Revivius , In that case I can fork the plugin and apply the pending PRs if that is Okay. Once that is done, I can publish the plugin on github itself.

Revivius commented 7 years ago

@Rahul-khandelwal, @markiewb; I didnt have time for the plugin for a while. I hope to merge this PR and fix some other bugs (eg background color in Debugging Window) in a week or so.

Geertjan mentioned this in his blog too and I sure would like to use NB and Darcula myself on JDK9 without exception dialogs.

debugger_sides

Rahul-khandelwal commented 7 years ago

Thanks @Revivius , We'll wait for next release of nb-darcula. Hope it comes soon.

GeertjanWielenga commented 7 years ago

Yes, would be great to have this integrated! :-) Fantastic plugin, except for this problem.

wattsec commented 7 years ago

Hi all,

My name is Julio and I also like this great plugin (thanks to all contributors).

It's been a while since there is a PR to fix this problem so I've decided to manually apply latest changes from pending PR along with some small updates to make it work with nightly version of netbeans and jdk9.

It works for me so if you want to use it until new version of the plugin is out you can download and see my changes at:

https://github.com/julioa/nb-darcula/releases/tag/jdk9

Hope it helps, Julio.

GeertjanWielenga commented 7 years ago

Thanks! Gj 

On Wednesday, July 19, 2017 9:33 PM, julioa <notifications@github.com> wrote:

Hi all,My name is Julio and I also like this great plugin (thanks to all contributors).It's been a while since there is a PR to fix this problem so I've decided to manually apply latest changes from pending PR along with some small updates to make it work with nightly version of netbeans and jdk9.It works for me so if you want to use it until new version of the plugin is out you can download and see my changes at:https://github.com/julioa/nb-darcula/releases/tag/jdk9Hope it helps, Julio.— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Revivius commented 7 years ago

Done in 09f3a4eabd6f664e6ab1d18f2bbc665336ec02ab. Will be available in v1.6. Thank you to everyone involved.