Revivius / nb-darcula

Darcula LAF for NetBeans
281 stars 83 forks source link

Make tab with unsaved changes more discernable #147

Open black-corvus opened 6 years ago

black-corvus commented 6 years ago

I love the darcula look and feel. I have just one issue.

In the standard look and feel, it is easier to notice tabs that have unsaved changes. Here is an example (file with unsaved changes on the right): regular

However, in the darcula look and feel, it seems to be harder to tell the difference. Here is an example (file with unsaved changes on the right): darcula

Notice that both the files are in a git repo so the tab text color is green. I think the combination of the color is causing the issue.

Is there any way to make the tab with unsaved changes more prominent?

Thank you.

Chris2011 commented 6 years ago

Afaik VS Code make a dot instead of a x but this is VS Code, I don't know atm how intelliJ this handles.

Chris2011 commented 6 years ago

But yes, I agree with that.

black-corvus commented 6 years ago

@Chris2011 I like the dot idea. Actually I was hoping for something like that. I think that is how Sublime Text does it too. But I'm not sure if that is possible (or easy to do) with a look and feel theme. I was thinking of just adding some more formatting to the text.

markiewb commented 6 years ago

There is API to change the title of tabs: http://bits.netbeans.org/dev/javadoc/org-netbeans-core-multitabs/overview-summary.html

Den 1 dec. 2017 7:28 em skrev "kodos84" notifications@github.com:

@Chris2011 https://github.com/chris2011 I like the dot idea. Actually I was hoping for something like that. I think that is how Sublime Text does it too. But I'm not sure if that is possible (or easy to do) with a look and feel theme.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Revivius/nb-darcula/issues/147#issuecomment-348571289, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxWR3iKuwsKxx9aNz_kAFBikRAx70Pqks5s8EVOgaJpZM4QyCNb .

black-corvus commented 6 years ago

@Chris2011 After doing some googling, I found this thread which mentions adding adding -J-Dnb.tabnames.html=false to the /etc/netbeans.conf file in the netbeans install directory to show an asterisk to indicate modified tabs. I just tried it (adding it to the space-separated netbeans_default_options="..." string) and it works!

I just thought you might like to know since you showed interest.

Chris2011 commented 6 years ago

@kodos84 thx I will test it too :)

Chris2011 commented 6 years ago

It works, it is a bit small and not so prominent but it is okish. But a better solution maybe more prominent would be better. Because if you would change the closing x it would be better I think because you see a real change. You wonder where is the x? Ahh I forgot to save. Smth like that.

TT-- commented 6 years ago

Does anyone know how to change the color of the active editor document tab? (It's hard to tell which it is in Darcula) Thanks. Maybe it's somewhere in here?