search

RevoGirl / RevoBoot

The RevoBoot-loader project
http://revogirl.wordpress.com/
Other
50 stars 138 forks source link

Default Config folder contents #3

Open ghost opened 13 years ago

ghost commented 13 years ago

Hi Sam

By default, RevoBoot-1.0-0.3 contains: /i386/config/ACPI/data.h /i386/config/settings.h

Can these be removed? as the template version of these files already exist.

RevoGirl commented 13 years ago

Uhm. Sure we can, but then people won't be able to compile it straight away. Will first have to copy the files. That is why I left them there.

We can fix this by adding a README file, in which we explain what they need to do. That should work. What do you think?

ghost commented 13 years ago

I see your point about the user not being able to compile RevoBoot without a settings.h file but as it is, not everyone will be able to boot with the directives set so is it worth supplying it?

I guess I'm referring here to #define ACPI_10_SUPPORT and will the user have a correctly setup boot disk to make use of: define LOAD_DSDT_TABLE_FROM_EXTRA_ACPI define PRE_LINKED_KERNEL_SUPPORT

But yes, a ReadMe explaining everything will definitely be the answer.

On the subject of ReadMe's, I have re-worked my (simple) version of RevStart to include more detailed help for the new user, though there is more to do yet. It also downloads your latest source code from git and uses the folder name based on your version/revision numbers.

RevoGirl commented 13 years ago

Whatever we do... it won't work for everyone so let's just remove the files and use the templates.

BTW: version and revision will be replaced with VERSION in the next update/commit. The reason for this is that I want to automate the process so that I don't have to change platform.c anymore. Just VERSION. Which of course is much more obvious and less likely to be overlooked / forgotten by me.

ghost commented 13 years ago

Just having the templates makes sense. Then the user can create their own settings.h file from the template by hand, or use the RevStart script to help them get started with a settings.h file. :)

Thanks for the heads up for the VERSION number only. Once you commit your next change I'll revise my script to use that instead of what I have now with version/revision.

flAked commented 13 years ago

In the last commits, both the data-template.h and data.h was commited, as well as settings.h.

This makes it a bit tedious to manage a local tree. The templates are good idea to a) force users to configure the settings and b) to let git ignore data.h and settings.h all together on updates

flAked commented 13 years ago

I think we can lose config/data-template.h and call config/data.h maybe includes.h to make it less confusing.

RevoGirl commented 13 years ago

We did not commit data-template.h nor data.h with the last commit. We only changed settings-template.h and settings-template.h (so that people can compile it without first having to copy the file.

flAked commented 13 years ago

Yah, sorry. I got confused with my repo fork. But wasn't there a revision where you had to copy every template?

RevoGirl commented 13 years ago

No problem. And yes we had that some time ago. Things keep changing don't they ;)