RevokeCash / revoke.cash

❌ Revoke or update your token approvals
https://revoke.cash
MIT License
674 stars 238 forks source link

Fix formatting in combination with i18n #124

Closed rkalis closed 1 year ago

rkalis commented 1 year ago

Right now all formatting is based around the English language version of Revoke.cash. Different languages may have longer words, causing formatting issues.

For example: if you edit an allowance (language set to Spanish) on a large screen, The buttons "Actualizar" and "Cancelar" fit. But when the cells are pressed more together due to being on a smaller screen, these buttons are cut off. If we remove the w-40 from AllowanceCell this gets fixed, but then we run into other formatting issues.

rkalis commented 1 year ago

We solved this by using conditional formatting based on the language in certain spots. This is absolutely not ideal, but it is what it is for now.