search

RevokeCash / revoke.cash

❌ Revoke or update your token approvals
https://revoke.cash
MIT License
674 stars 238 forks source link

Add indication of old approvals #159

Closed rkalis closed 9 months ago

rkalis commented 10 months ago

Approvals that have been open for a long time are prime candidates for revoking.

natebeauregard commented 9 months ago

@rkalis I like the project a lot, I can take a look at this. Would adding an icon/tooltip that appears to the right of the last updated column text be sufficient? Also what do you think the cutoff should be for showing the indication (over 6 months, over 3 months, etc.)?

rkalis commented 9 months ago

Hey @natebeauregard, that sounds great! Yeah I think having a tooltip that says something like "This approval is over X months/years old" sounds great.

We have a similar thing for spenders that were involved in hacks on the "Authorized Spender" column (https://github.com/RevokeCash/revoke.cash/blob/master/components/allowances/dashboard/cells/SpenderCell.tsx#L48)

CleanShot 2024-01-03 at 09 16 32@2x

I think if we do a similar thing on the Last Updated column, but a bit less "dangerous-looking" that would be great (maybe a yellow sign instead of a red one - not sure what the best representation would be). Let's start with checking >12 months old.

Let me know if you run into any issues!

bobeu commented 9 months ago

@rkalis Seems like @natebeauregard is on this. If it is still open, I'd like to hop in.

rkalis commented 9 months ago

Hey @bobeu, thanks for your interest! I just merged #177 yesterday, but I forgot to close this issue. I see you also commented on another issue, I'll add some more information there!

bobeu commented 9 months ago

Hey @bobeu, thanks for your interest! I just merged #177 yesterday, but I forgot to close this issue. I see you also commented on another issue, I'll add some more information there!

That's great. Thank you.