search

RevokeCash / revoke.cash

❌ Revoke or update your token approvals
https://revoke.cash
MIT License
674 stars 238 forks source link

:sparkles: Add text filtering by networks #161

Closed kalpovskii closed 9 months ago

kalpovskii commented 10 months ago

Issue #157

I tried to implement text filtering, but the thing is that <Select /> has it's own input and formatOptionLabel={displayOption} lies on top of it. So, I reduced logo's size :/

Should I have written a separate implementation of input in displayOption? Or are there other ways..?

image

vercel[bot] commented 10 months ago

@kalpovskii is attempting to deploy a commit to the Kalis Software Team on Vercel.

A member of the Team first needs to authorize it.

kalpovskii commented 10 months ago

And it works, but the code and UI look weird

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revoke-cash ❌ Failed (Inspect) Jan 4, 2024 11:57am
rkalis commented 9 months ago

Hey Andrei, thanks for creating this PR!

I think the best way to solve these formatting issues is to move the search bar into the dropdown (instead of in the control element) - such as in this example: https://github.com/JedWatson/react-select/issues/2393

It looks like this is not natively supported by react-select, but they do offer an example of how you could achieve something like that here: https://react-select.com/advanced#experimental.

This looks like it will take quite a bit of work to get right. If you like, feel free to try to tackle it, otherwise I will also look into it when I find the time.

rkalis commented 9 months ago

Hey @kalpovskii, thank you again for starting the work on this and getting the ball rolling. @sabalpoudel implemented the UI updates that we discussed (#180), so I will close this PR.