search

RevokeCash / revoke.cash

❌ Revoke or update your token approvals
https://revoke.cash
MIT License
674 stars 238 forks source link

Steen3s nft pricing resevoir #183

Closed Steen3S closed 7 months ago

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revoke-cash ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2024 3:12am
rkalis commented 8 months ago

This looks great. I changed some small things about the rate limiting to allow for more concurrent requests. But I'm running into issues where the Vercel Edge function times out for certain NFT collections (looks like mainly for collections without any pricing data - I manually checked a few by calling the Reservoir directly).

This timeout is only on the first visit (seems like Reservoir needs to still index these collections at first visit or something), which makes it hard to debug.

Since this only happens for collections without real pricing info any way, it is alright, since we can just return null as price. But right now it takes 10 seconds before the Edge function times out. We probably want to make sure the Edge function times out earlier if it doesn't get a response from Reservoir in like 3-4 seconds, so that it doesn't cause the frontend to stall for 10 seconds.