search

RevokeCash / revoke.cash

❌ Revoke or update your token approvals
https://revoke.cash
MIT License
674 stars 238 forks source link

Add 'Last Cancelled' field to Permit Signatures table #187

Closed bobeu closed 7 months ago

bobeu commented 8 months ago

Added a new column for the last-cancelled. 7 files were modified.

Current look

1 revoke 2 revoke

vercel[bot] commented 8 months ago

@bobeu is attempting to deploy a commit to the Kalis Software Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revoke-cash ❌ Failed (Inspect) Feb 21, 2024 5:15pm
bobeu commented 8 months ago

Hey @bobeu, thank you for opening this PR, super helpful! I left a few comments throughout the code with some requested changes.

Ok great. Thank you for the feedback. I'll fix that shortly.

bobeu commented 8 months ago

Hi @rkalis, just wanted to update you that I have added the last commit in PermitPanel.tsx. However, I faced a major issue while calling an async operation in the same file where the tokens are being filtered. Despite trying multiple times, it wouldn't return any value to the filter function because of the async marking. I am confident that the issue is due to a couple of tokens that need to be tested in this case, causing the function to exit before the async operation completes. Right now, the program runs fine but I'll ask if you have any idea to improve the filter operation.

rkalis commented 8 months ago

Thanks for the updates. Looks good.Thank you for the great work, you can consider the work done from your end 🥳

I will look into the issues you mentioned and try to fix them on my end before merging it.

rkalis commented 8 months ago

Alright it should all be working now. I just realised that it is probably good to add a similar field to the "marketplace signatures" as well. I will add that later this week as well and then merge + deploy this.

rkalis commented 7 months ago

Hey @bobeu, thanks once again for the great work. I just merged this into a new branch, where I will add the changes mentioned above before deploying it to the production Revoke.cash website.

bobeu commented 7 months ago

Thanks for the updates. Looks good.Thank you for the great work, you can consider the work done from your end 🥳

I will look into the issues you mentioned and try to fix them on my end before merging it.

OK Great