RevokeCash / revoke.cash

❌ Revoke or update your token approvals
https://revoke.cash
MIT License
674 stars 238 forks source link

Support LUKSO with LSP7/8 tokens #206

Open rkalis opened 6 months ago

rkalis commented 6 months ago

LUKSO is an EVM compatible network, so it can be integrated like other networks. However, they've developed separate token standards called LSP7 (their ERC20) and LSP8 (their ERC721).

The LSP7 token standard doesn't really solve any of the problems associated with token approvals, although the LSP8 standard does improve some of the security issues with ERC721 token approvals.

Despite this, these tokens standards do change all of the interfaces / names compared to their Ethereum counterparts for some reason (e.g. OperatorAuthorizationChanged instead of Approval events are emitted and authorizedAmountFor is called instead of allowance to get the current token approval value).

This makes integrating existing Ethereum applications (including Revoke.cash) with these tokens a huge pain (again, without a lot of gain). It should be possible to create an special case for LUKSO's token standards in the future, but for now I don't see this being worth the effort.