search

RevolutionPi / piControl

Kernel module for data exchange with RevPi I/O-Modules and Gateways
81 stars 24 forks source link

add support for SE device (machine_type) #68

Closed zhan-kunbus closed 2 years ago

zhan-kunbus commented 2 years ago

following changes are made for Core SE and Connect SE:

  1. add SE device to revpi_machine
  2. set the machine_type in piControlInit()
  3. check machine_type, if not SE call revpi_gate_init();
  4. add code for Connect SE in every appearance of REVPI_CONNECT
  5. add code for Core SE in every appearance of REVPI_CORE
linosanfilippo-kunbus commented 2 years ago

Please use this approach instead of the one with the variants. This is more straightforward and does not introduce as much more complexity as the other approach does.

zhan-kunbus commented 2 years ago

Please use this approach instead of the one with the variants. This is more straightforward and does not introduce as much more complexity as the other approach does.

OK

zhan-kunbus commented 2 years ago

From a quick glance this draft looks ok, but please dont use CMN_ASSERT in the final version

are you mean no assert ?

linosanfilippo-kunbus commented 2 years ago

Yes, you use CMN_ASSERT in your draft code. We dont want to use this macro and we dont want to have asserts in production code at all