search

RevolutionPi / piControl

Kernel module for data exchange with RevPi I/O-Modules and Gateways
81 stars 24 forks source link

piTest: Add Connect 4 as known device #88

Closed nbuchwitz closed 1 year ago

nbuchwitz commented 1 year ago

Besides the implementation of the Connect 4 support in piControl, we need to add the device as known in piTest.

l1k commented 1 year ago

I don't think a MODGATECOM_IDResp struct needs to be added just for the userspace support. That struct is only needed internally for the kernel-side code AFAICS. And the struct is added on the connect4 branch in commit nbuchwitz/piControl@1b93f6c1d6eb5e61001cfe6a81330540cd10109c.

However, this present pull request should add the definition of KUNBUS_FW_DESCR_TYP_PI_CONNECT_4 in common_define.h so that number 136 is reserved and there's no risk of accidentally handing that number out to a different device. Granted, the chance of that happening is low but seems good housekeeping nonetheless.

nbuchwitz commented 1 year ago

@l1k makes sense. I've added the ID in a separate commit and re-ordered the commits, so the id is defined before it's used in a later commit.