search

RevolutionPi / piControl

Kernel module for data exchange with RevPi I/O-Modules and Gateways
81 stars 24 forks source link

Add RO module #98

Closed jruelli closed 1 year ago

jruelli commented 1 year ago

Signed-off-by: Jannis Ruellmann j.ruellmann@kunbus.com

iluminat23 commented 1 year ago

Your Signed-off-by is not correct it should be Signed-off-by: Jannis Ruellmann <j.ruellmann@kunbus.com> The easiest way is to use -s when doing the commit. You can also do this with git commit --amend -s, then it will add the correct Signed-off-by, but only if it is not yet present.

nbuchwitz commented 1 year ago

Please do not call it piro. The official name is RO -> KUNBUS_FW_DESCR_TYP_PI_RO

iluminat23 commented 1 year ago

It would then also be nice to have the correct full name of the module in the commit message!