search

RevolutionUC / revolutionuc-website

(legacy) Development repository for RevolutionUC website
MIT License
3 stars 4 forks source link

An in-range update of express-validator is breaking the build 🚨 #107

Closed greenkeeper[bot] closed 6 years ago

greenkeeper[bot] commented 7 years ago

Version 3.2.1 of express-validator just got published.

Branch Build failing 🚨
Dependency express-validator
Current Version 3.2.0
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

express-validator is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them. I recommend you give this issue a very high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/RevolutionUC/revolutionuc-website/builds/251623427?utm_source=github_status&utm_medium=notification)
Release Notes v3.2.1
  • Add deprecation warnings to req.validationErrors() and req.asyncValidationErrors()
  • Add support for Node 8
  • #354 - Don't throw error when validator returns null/undefined
  • #318, #348, #350, #352 - Fix lots of problems in TypeScript typings!
  • #366 - Tests rewritten as unit tests ⚠️ (should make contributors' lives' easier!)
Commits

The new version differs by 30 commits.

  • e27ed6b 3.2.1
  • 30016f9 typescript: add support for async customValidators
  • 3780f87 Merge pull request #366 from ctavan/tests-refactor
  • 7b5d392 Tests: don't use syntax unsupported to Node 4
  • b1229eb Fix lint problems
  • d308410 eslint: use ES6
  • 44c3214 Tests: move everything to unit tests
  • b4c0f5a git: ignore .DS_Store from OSX and .vscode
  • 4d302cb Remove unused Promise variable
  • 799a817 CI: Add node 8
  • cd05543 Update typescript version
  • bcb6744 Merge pull request #354 from cotko/master
  • 2fb0afc eslint fixes
  • 9df002e Treat null and undefined as unexpected values returned by validators and print warning for each validator which returns them
  • 092cd32 Treat null and undefined as unexpected values returned by validators and print warning for each validator which returns them

There are 30 commits in total.

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 3.2.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.