Revolutionary-Games / Thrive

The main repository for the development of the evolution game Thrive.
https://revolutionarygamesstudio.com/
Other
2.78k stars 495 forks source link

RichTextLabel not updating its height when rect size is changed with FitContentHeight property enabled. #2236

Open athariqk opened 3 years ago

athariqk commented 3 years ago

This is to track a workaround needed to fix bug mentioned in the title, which will possibly be irrelevant in future Godot versions. https://github.com/Revolutionary-Games/Thrive/blob/7de5bd26a1f7f07ed826a408cd80d800ec6f641e/src/gui_common/CustomRichTextLabel.cs#L260

hhyyrylainen commented 2 years ago

I found that the constant _Draw calls sap a ton of performance in the editor on the report tab, so I'll try to make it so that this workaround only needs to run once when the text content is changed.

hhyyrylainen commented 3 months ago

This should be checked again with Godot 4 now being used.