Revolutionary-Games / Thrive

The main repository for the development of the evolution game Thrive.
https://revolutionarygamesstudio.com/
Other
2.81k stars 501 forks source link

Update to Godot 3.4 #2742

Closed skyace65 closed 2 years ago

skyace65 commented 2 years ago

Godot 3.4 officially released today. a blog post covering the main changes can be found here.

Unfortunately thrive does not currently build on 3.4. There are five errors related to ulong and long types. Typically 3.x releases shouldn't break compatibility, and I'm not great at C# so I'm not sure what's going on here. Either something in the engine broke, changed, or it's finding errors it wasn't finding before. If something in Godot is broken an issue should be opened on its repository.

Blisto91 commented 2 years ago

The minor version increment is allowed to have minor breakage according to their docs Though I haven't looked into Thrives case

hhyyrylainen commented 2 years ago

I haven't also tried building GodotSteam (but it seems they already tagged a version for 3.4, so probably no issues there) for the new version. Due to me being very busy with finalizing the steam release, I think this engine version update should be pushed back to the release after 0.5.6.