search

Revolutionary-Games / Thrive

The main repository for the development of the evolution game Thrive.
https://revolutionarygamesstudio.com/
Other
2.82k stars 500 forks source link

Fix the properties in Tool attribute classes almost always breaking automatically #2751

Open hhyyrylainen opened 2 years ago

hhyyrylainen commented 2 years ago

Lately with the new custom dialog classes I've noticed that Godot almost always automatically breaks the main scene like this: kuva

Might be an engine bug related to the compiling of C# code on load or something causing the properties to not be ready by the time the main scene is loaded.

hhyyrylainen commented 2 years ago

This is really starting to annoy me. Perhaps if we moved that dialog box to a child scene / class, then it would work as the first loaded scene wouldn't have that kind of custom property in it?.

hhyyrylainen commented 2 years ago

Found another victim of this bug: 2021-11-21_11 37 19 1581

I think we need an automatic check against this as this seems to happen super often.

I'll go through all the tutorial scenes on my modding branch and fix the titles.

hhyyrylainen commented 2 years ago

What if the "tool" attributes are commented out? Maybe that would help. It would 100% be better to not have them display properly in the editor than to constantly, I mean yesterday I probably re-set a window's title like 10 times, fight against this.

athariqk commented 2 years ago

That's probably for the best, and if live visual feedback is needed then the tool attribute can just be uncommented locally.

hhyyrylainen commented 4 months ago

With the update to Godot 4 this is hopefully possible to do now.