Revolutionary-Games / Thrive

The main repository for the development of the evolution game Thrive.
https://revolutionarygamesstudio.com/
Other
2.85k stars 507 forks source link

Godot bug: Colour picker doesn't work when window is not default sized #2803

Open FuJa0815 opened 2 years ago

FuJa0815 commented 2 years ago

I think we should remove this color picker: image It's broken and useless

FuJa0815 commented 2 years ago

https://godotengine.org/qa/34676/how-do-i-customize-a-colorpicker

hhyyrylainen commented 2 years ago

It's not actually broken and useless, it works if you don't resize the game window from 720p. I think this was discussed before, I can't remember where. There might be an existing Godot issue, if not one should be opened to them (basically when the scaling type is used that is in Thrive, and the window is not the default size the colour picker doesn't correctly map to right coordinates) Could someone look that up / do that? I'm very busy.

RacerBG commented 2 years ago

Yes, I can confirm that on low (window) resolutions the colour picker does not work. It even crashed the game but the error log was empty.

84634E1A607A commented 2 years ago

https://github.com/Revolutionary-Games/Thrive/issues/2459#issuecomment-906084578

hhyyrylainen commented 2 years ago

Thanks for the link, that's indeed where we were discussing this before.

84634E1A607A commented 2 years ago

Opened an issue:

https://github.com/godotengine/godot/issues/57343

84634E1A607A commented 2 years ago

Let's reopen this to track Godot fix.

hhyyrylainen commented 5 months ago

This should be checked that it works in Godot 4.