search

Revolutionary-Games / Thrive

The main repository for the development of the evolution game Thrive.
https://revolutionarygamesstudio.com/
Other
2.81k stars 501 forks source link

Crash after a misclick while autosaving at the editor screen #3959

Open Teashrock opened 1 year ago

Teashrock commented 1 year ago

I was playing normally on my laptop, then pressed the evolution button to enter the editor screen. Upon entering, the game started to autosave, but that moment I clicked somewhere occasionally, or pressed some button. The fact is, after the autosave finished, the game immediately crashed for some reason. Log file is below.

To Reproduce Steps to reproduce the behaviour:

  1. Enable autosave in game preferences.
  2. Play normally until the evolution button is active.
  3. Click the evolution button.
  4. See an autosave happening.
  5. Make an occasional misclick.
  6. The autosave finishes.
  7. The game crashes immediately.

Expected behaviour Even if making misclicks, nothing should happen, so I'm reporting this.

System info (please complete the following information):

Logs https://pastebin.com/JmM3VEvv

Additional context The autosave mentioned above is intact and can be loaded.

84634E1A607A commented 1 year ago

Looking from your process' return code, the misclick made windows believe that Thrive is unresponsive (it surely is when performing an autosave) and forced to close it (by sending a kill signal). When the autosave completed, Godot received that signal and quited.

Teashrock commented 1 year ago

@84634E1A607A So, just a Windows bug? Can I close the issue?

84634E1A607A commented 1 year ago

I'm not quite sure, so let's leave this open for a while.

Teashrock commented 1 year ago

I have just closed Thrive through Windows "kill the hang process". It has also returned some non-standard code, but there was no ERROR: Index p_shape_index = line this time.

84634E1A607A commented 1 year ago

That line is a quite common error (by Godot), it doesn't cause a crash.

hhyyrylainen commented 1 year ago

The index shape problem is the engine physics system which has been bugged for years, but they've not done anything to fix it. Actually basically all game crashes seem to also come from the physics system: https://github.com/Revolutionary-Games/Thrive/issues/1282

It is plausible that you just were extremely unlucky and that the engine crashed due to the physics problem just as the save finished and the game started running again. If you happen to have any, crash dump files (the launcher should offer to report a crash) might be useful, as that would probe that the game actually crashed, though we've got plenty of duplicate reports (hundreds in fact) of the physics crash so one more crash dump wouldn't be that useful.

I'm guessing that as one of the log messages is cutoff indicating that the game crashed while it was outputting text and not in a controlled manner.