search

Revolutionary-Games / Thrive

The main repository for the development of the evolution game Thrive.
https://revolutionarygamesstudio.com/
Other
2.77k stars 494 forks source link

Test all controller type icon sets (and controller detection) #4013

Closed hhyyrylainen closed 1 year ago

hhyyrylainen commented 1 year ago

I have only a few types of controllers so I can't test that all of these icon sets are correctly in the game (and don't have typos in the icon file names or something like that). Here's what needs testing:

Also if any of those controllers don't use the right icons, then the controller name detection code needs to be fixed for that controller.

matthewpaul-us commented 1 year ago

What do we want to see in terms of testing for these? I hooked up an XboxOne controller, it was detected, and I was able to see the correct icons for the controller. I didn't get pics of all of them or test all of them, as somewhere along picking commits my copy lost the ability to detect the controller. I haven't had a chance to track down the controller detection or the icon sets yet, but wanted to know whether we needed to test every button for a matching icon or if a single button picking the correct icon proves the controller's icon set is chosen correctly. Is that the case?

On running Thrive, here is the controller detection output: First connected controller is: XInput Gamepad

Here are bumpers: image

I can also confirm that triggers and left stick show icons. I didn't get a chance to check face buttons due to the controller not being recognized on subsequent runs. I'll keep fiddling with it to see if I can confirm the rest. I also have a playstation 4 controller. If the controller still works, I'll get some testing for that one as well.

hhyyrylainen commented 1 year ago

I actually ended up adding an option in the graphics settings to force a specific controller icon set, so testing with different controllers is not really necessary (unless the type detection is incorrect, but that is also a bit limited as it can only use the controller name).

This issue was mostly just for checking that it doesn't happen to be the case that some controller variant of a button has an unexpected filename (and would fail to load because of that). I'll close this as likely working for now, if there are some broken icons after all a separate issue can be opened about fixing them.