Revolutionary-Games / Thrive

The main repository for the development of the evolution game Thrive.
https://revolutionarygamesstudio.com/
Other
2.86k stars 508 forks source link

Add new ice shelf theme #5605

Closed CI09 closed 1 month ago

CI09 commented 1 month ago

Brief Description of What This PR Does

Adds theme "Solstice" by QuantumCrab

Related Issues

closes #5602

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

Before merging all CI jobs should finish on this PR without errors, if there are automatically detected style issues they should be fixed by the PR author. Merging must follow our styleguide.

revolutionary-bot commented 1 month ago

We are currently in feature freeze until the next release. If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

hhyyrylainen commented 1 month ago

Shouldn't this be marked as closing https://github.com/Revolutionary-Games/Thrive/issues/5602?

hhyyrylainen commented 1 month ago

Also isn't the music track pretty quiet so using 0.6 as the volume seems a bit weird to me?

CI09 commented 1 month ago

To my ear the file I downloaded from dev center is quite loud later on, even louder than microbe theme 7 which has 0.6 volume set

hhyyrylainen commented 1 month ago

It's probably fine then if you tested in game and adjusted the volume to be in line with the other microbe tracks.

CI09 commented 1 month ago

Well I didn't test-adjust it, just checked the first time if works because it is really tedious to re-run game every time wrong soundtrack plays but I just believe it should be fine ☺️