Make cell membrane more wavy

dligr commented 3 weeks ago

Brief Description of What This PR Does

Continuing from #5613

Makes membranes' vertical waves go in two directions (not only in one, as before)
Adjusts normals based on those waves to make shadows and the fresnel shader work correctly.

https://github.com/user-attachments/assets/52a74957-319c-48a8-9900-a9835d6df3a8

https://github.com/user-attachments/assets/945cf9d0-2eaf-42b6-b13f-a442092a995d

I don't think this should make it into 0.7.1, as there is the visual aspect to discuss and the performance aspect to evaluate.

Related Issues

--

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

[x] PR author has checked that this PR works as intended and doesn't break existing features: https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist (this is important as to not waste the time of Thrive team members reviewing this PR)
[x] Initial code review passed (this and further items should not be checked by the PR author)
[ ] Functionality is confirmed working by another person (see above checklist link)
[x] Final code review is passed and code conforms to the styleguide.

Before merging all CI jobs should finish on this PR without errors, if there are automatically detected style issues they should be fixed by the PR author. Merging must follow our styleguide.

revolutionary-bot commented 3 weeks ago

We are currently in feature freeze until the next release. If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

hhyyrylainen commented 3 weeks ago

I put this in the 0.8.0 milestone as I assume this will be ready soon?

dligr commented 3 weeks ago

It will likely be. I want to make sure that I haven't made a mistake in the normal calculations, and see if those waves can be made more visible on smaller microbes.

There also needs to be some feedback on the visual change.

dligr commented 1 week ago

There was a bunch of issues with the formula used, but they should be fixed now. So, this is ready for review.

Some demo videos:

https://github.com/user-attachments/assets/d35ebd96-4a74-4b68-a022-f58e6cb3d72b

https://github.com/user-attachments/assets/d9b50fa9-a820-4630-8d5b-0608690b46f4

On AI microbes:

https://github.com/user-attachments/assets/7222497c-1c2e-46bb-800f-5389c4df1488

hhyyrylainen commented 1 week ago

I think the feedback was generally favourable but maybe the effect strength could be reduced like 15% and then this would be good to go?

Revolutionary-Games / Thrive

Make cell membrane more wavy #5627