search

Rex2002 / sound-investments

1 stars 0 forks source link

UI: Legend-key swaps names when sonifying two stocks #228

Closed MalteRichert closed 1 year ago

MalteRichert commented 1 year ago
image

The pink line should definitely be Apple but is shown to be ABIVAX. Also, I suspect that ABIVAX shouldn't exist for the early 80s only but for the more recent years. Something seems to be wrong with the dates/padding there

Rex2002 commented 1 year ago

maybe related to #214 ?

ArtInLines commented 1 year ago

I'm working on #214 rn, so I can take a look at this too

nichtLehdev commented 1 year ago

Oh so you got that issue too.. I couldn't replicate it and thought I looked wrongly the one time

Lizzyhara commented 1 year ago

colors[sonifiableNames.length-i] in MusicSceneConroller line 164 should fix it.

Lizzyhara commented 1 year ago

Will be tested once we get our new api keys.

ArtInLines commented 1 year ago

@Lizzyhara mit neuen API-Keys getestet und das scheint nicht zu funktionieren: grafik

ArtInLines commented 1 year ago

I think the issue is int he StateManager around line 297. The musicDataPrices is not guaranteed to be parallel to the sonifiableNames. I will check if that fixes the issue shortly

Lizzyhara commented 1 year ago

colors[sonifiableNames.length-i-1] in MusicSceneConroller line 164 fixxes it. But it is not a beautiful solution shall I push it or better not ?

ArtInLines commented 1 year ago

@Lizzyhara I'm very sure that that wouldn't actually work for different inputs. The problem is that the prices are ordered differently than the names. I fixed that in #238. Your solution would most probably only work sometimes