search

RexOps / rexify-website

Website content and code for rexify.org
https://www.rexify.org
14 stars 31 forks source link

Check for valid HTML5 #130

Closed ferki closed 5 years ago

ferki commented 5 years ago

This PR enables HTML5 linting of the generated pages, and fails hard if there are any problems.

The built-in linter plugin simply prints warnings, but otherwise continues happily. In order to make it more useful with our Travis pipeline, I decided to simply import the standard plugin and patched it to fail on errors instead.

This patch could be made optional, and then it might be a good candidate to send upstream. If there's a better/simpler approach to override the behavior, don't hesitate to let me know :)

ferki commented 5 years ago

@ehuelsmann: I've added a few followup commits, so it's easier to review the additional changes. I will squash them away before merging.

I addressed your remaining feedback item, and decided to add a fatal attribute to the plugin control calling die() at the end or not.

ehuelsmann commented 5 years ago

Very nice improvement! I love how the site becomes better every monh!

ehuelsmann commented 5 years ago

oh. dang. you wanted to squash them!

ferki commented 5 years ago

Since it's still very fresh, and it's probably not used by anyone else, I decided to quickly squash on master after discussing it with @ehuelsmann.

If you already pulled, you might need to reset your local master branch to the current one. In this case, sorry for the inconvenience!

To lower the likelihood of simiIar cases in the future, I'll use the autosquashable commits only in draft PRs, and I'll squash directly on mergeable PRs if needed.