Invalid quotation in %burl and %yurl diff tool arguments

[GoogleCodeExporter]

Reported on the mailing list:
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=30410
98

I set up an external diff viewer in Settings -> Diff Viewer -> External:

"C:\DiffTool.exe" /p1=%burl /p2=%yurl %base %mine

When I choose "Show changes" from the Log window, TortoiseSVN misses the 
closing quotes in %burl and %yurl arguments, for example:

"C:\DiffTool.exe" /p1="http://svn.local/svn/MyProject/trunk/ReadMe.html 
/p2=""http://svn.local/svn/MyProject/trunk/ReadMe.html 
"C:\Users\ArtemA\AppData\Local\Temp\ReadMe.html-rev1407.svn001.tmp.html" 
"C:\Users\ArtemA\AppData\Local\Temp\ReadMe.html-rev1408.svn001.tmp.html"

TortoiseSVN version: 1.7.11, Build 23600

Original issue reported on code.google.com by tortoisesvn on 5 Jan 2013 at 9:46

[GoogleCodeExporter]

this seems to be a bigger issue: the end quote is appended in code, but somehow 
doesn't get appended to the string:
AppUtils.cpp, line 381:
    if (viewer.Find(_T("%burl")) >= 0)
    {
        CString s = L"\""+url1.GetSVNPathString();
        s += L"\"";
        viewer.Replace(_T("%burl"), s);
    }

Even though the line
s += L"\"";
is there, it doesn't actually append the end quote.

Have to dig deeper...

Original comment by tortoisesvn on 5 Jan 2013 at 9:49

[GoogleCodeExporter]

This issue was closed by revision r23789.

Original comment by tortoisesvn on 5 Jan 2013 at 12:20

• Changed state: Fixed

[GoogleCodeExporter]

This issue was closed by revision r23790.

Original comment by tortoisesvn on 5 Jan 2013 at 12:23