search

Rexeh / joystick-diagrams

Automatically output your tool/game HID configs into printable diagrams with all your binds.
https://joystick-diagrams.com
GNU General Public License v2.0
146 stars 22 forks source link

Added a initial version of a visualizer #38

Closed Bahamada closed 3 years ago

Bahamada commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #38 (5c23a5f) into master (62b23c6) will decrease coverage by 14.27%. The diff coverage is 28.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #38       +/-   ##
===========================================
- Coverage   90.37%   76.09%   -14.28%     
===========================================
  Files          11       13        +2     
  Lines        1080     1443      +363     
===========================================
+ Hits          976     1098      +122     
- Misses        104      345      +241
Impacted Files Coverage Δ
src/classes/visualizer.py 26.85% <26.85%> (ø)
src/joystick_diagrams.py 54.66% <40.54%> (+0.38%) :arrow_up:
src/classes/templater.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62b23c6...5bf80fb. Read the comment docs.

Rexeh commented 3 years ago

Sorry it's taken so long to review this, and thank you for your PR and time spent on this!

There are some cool concepts here, but a bit away from where I want to head with the tool at this stage, I'm also most likely using a more focussed library for device interaction, pygame is great but a bit too much and trying to keep the dependencies down where I can.

I liked your interaction with the SVG, so appreciated to give me some ideas for things like modifiers which will most likely require some SVG manipulation.

All the best,

Rob