Rexeh / joystick-diagrams

Automatically output your tool/game HID configs into printable diagrams with all your binds.

https://joystick-diagrams.com

GNU General Public License v2.0

146 stars 22 forks source link

Trim some words from Label, force some mining one. #54

Closed FlisherOfatale closed 3 years ago

FlisherOfatale commented 3 years ago

Added some quick code to hijack very long labels. Fixed some that didn't make sense for mining.

FlisherOfatale commented 3 years ago

Removed a check for "devices" xml node as it's not in the Star Citizen 3.13 files. Additional suggestion: Update documentation as the game now save current binding automatically and doesn't require export from the game client as mentionned on the page https://joystick-diagrams.com/features/ in the URL pointing to the RSI Guide

Path of the xml file in the current live version (3.13): \Roberts Space Industries\StarCitizen\LIVE\USER\Client\0\Profiles\default\actionmaps.xml

FlisherOfatale commented 3 years ago

closing / reopening as second comit seem to have cause the build to fail

codecov[bot] commented 3 years ago

Codecov Report

Merging #54 (19d88ce) into 1.5 (4d0b30e) will decrease coverage by 0.22%. The diff coverage is 60.00%.

@@            Coverage Diff             @@
##              1.5      #54      +/-   ##
==========================================
- Coverage   91.46%   91.23%   -0.23%     
==========================================
  Files          12       12              
  Lines        1359     1369      +10     
==========================================
+ Hits         1243     1249       +6     
- Misses        116      120       +4

Impacted Files	Coverage Δ
src/adaptors/star_citizen.py	`94.85% <60.00%> (-2.77%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d0b30e...19d88ce. Read the comment docs.

FlisherOfatale commented 3 years ago

Added a data to test the ifcs and toggle function in test case, but test case not created yet. Added 3 test-case files from Star Citizen 3.13 File from new profile:

actionmaps_userfolder_blank.xml -> file from the user folder, natively saved since 3.13 in "\Roberts Space Industries\StarCitizen\LIVE\USER\Client\0\Profiles\default\actionmaps.xml"
actionmapsvalid.xml -> adapted from valid.xml layout_all_exported_blank.xml ->Exported file like as the old mechanism, it still exist, format is different (actionmap id instead of name, different header, but the binding part seem identical so the parsing work)

FlisherOfatale commented 3 years ago

cancelling PR, will add proper test case and replace xml as the format from 3.12 doesn't exist anymore, but 2 new one came with 3.13