search

Reyder95 / sdvx-tracker-frontend

Website designed to help SOUND VOLTEX players track their scores among simulators, and even official cabinet if they desire. The design route taken through this project will also allow players to keep track of custom charts as well.
3 stars 0 forks source link

Score Submission Validation #107

Closed kelbaum closed 4 years ago

kelbaum commented 4 years ago

This is a mix of bug and feature request. As of right now, there is only a case check in song-view.js for scores between 0 and 10,000,000. No validation for clear type.

For example, I can submit a 10,000,000 score for other clear types when it should be Perfect Ultimate Chain only.

Another example, submitting a score of 1 to Ultimate Chain and Perfect Ultimate Chain clear types.

Suggestion: Add clear type case checks in addScoreToAPI() function in song-view.js before making call to addScore() function in api-calls.js.

Reyder95 commented 4 years ago

Yeah I was planning on doing a few things. For one, when typing 10,000,000 it would instantly select PUC. However what do you think would be a plausible Ultimate Chain? I think at the moment something like PUC is the only thing you can safely check.

kelbaum commented 4 years ago

You could refactor how you submit a score by adding a chain attribute. You know that it requires max chain to be counted as UC or PUC. Having only score won't be feasible.

Reyder95 commented 4 years ago

Indeed but as it stands adding more would be sort of annoying to do. Since things are manual, simplicity is what I went with. It's entirely an honor system so things like that aren't so bad to deal with. I'll be just checking PUC for now. If something changes in the future I'll handle UC as well.