search

Reza-Safdari / SimSiam-91.9-top1-acc-on-CIFAR10

Pytorch implementation of the paper Exploring Simple Siamese Representation Learning.
66 stars 16 forks source link

KNN Metric #2

Open AminJun opened 3 years ago

AminJun commented 3 years ago

Hi there.

I was reading through the code and something caught my attention. In the implementation of KNN, the training_data features have been normalized and then in a matrix multiplication form, they are multiplied by the features of the eval_data. It looks like you are looking at something like Cosine Similarity but not exactly (cause you don't normalize the eval_data). Is there a reason why you did this? Or is it just a mistake?

dengandong commented 3 years ago

same question

Reza-Safdari commented 2 years ago

Hi. Thanks for mentioning this issue. It is a mistake and I'll fix it asap.