search

Rezi / sugar-css

Other
36 stars 2 forks source link

Fix: #3 #5

Closed a-kla closed 2 months ago

netlify[bot] commented 2 months ago

Deploy Preview for venerable-banoffee-88d0c6 ready!

Name Link
Latest commit 35263ae013b152d9dc44c50b71da2571ff45bc73
Latest deploy log https://app.netlify.com/sites/venerable-banoffee-88d0c6/deploys/668b903622ae0c0008a81a8c
Deploy Preview https://deploy-preview-5--venerable-banoffee-88d0c6.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 89
Accessibility: 100
Best Practices: 100
SEO: 91
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Rezi commented 2 months ago

Unfortunately this won't fix it. We need ?inline in order to convert scss to css. The fix is however coming with more complex solution. Fixing some bad regexes and manually supplying comments.

a-kla commented 2 months ago

We need ?inline in order to convert scss to css.

Oh yes sorry, i missed the @for in the Grid and thought it's just plan css with scss style comments.

Rezi commented 2 months ago

No issue at all, thanks you very much for your effort and pointing to broken parts. THANKS