search

Rezmason / matrix

matrix (web-based green code rain, made with love)
https://rezmason.github.io/matrix
MIT License
3.29k stars 212 forks source link

Image displays upside-down with effect=image #37

Closed jesse-mend closed 1 year ago

jesse-mend commented 1 year ago

I'm experimenting with a screensaver for my work machine which displays the effect over my company logo. Everything is working great, except that the image displays upside-down for some reason! I checked the demo image (Eagle rock) and discovered that this is true there, too.

To reproduce: effect=image&url=[someUrl]

Rezmason commented 1 year ago

D'oh! 🤦 Thank you!

Rezmason commented 1 year ago

Oh actually I'll flip the uv in the shader so the REGL and WebGPU renderers are more similar, which was what led me to remove the flipY in the first place

Rezmason commented 1 year ago

Spent some time poking around, and I decided I'll try to flipY in REGL and in WebGPU.

Future updates to the project may reveal that my existing code hides some coordinate system differences, but that can't hold up this bugfix!

Rezmason commented 1 year ago

Fixed!

A bunch of stuff had been broken by that "removing flipY" commit, oops. Now the WebGPU and REGL projects are both in a better spot. Thanks for reporting the issue!

jesse-mend commented 1 year ago

Woot! Sure thing! Thanks for investigating & fixing! 😃