RezwanAhmed123 / pe

0 stars 0 forks source link

Names with special characters are unable to be added to the app #7

Open RezwanAhmed123 opened 2 weeks ago

RezwanAhmed123 commented 2 weeks ago

Clients with names containing "/" and "-" are unable to be added to the app. In context of Singapore this is a problem as there are many people with the "/" in the name such as "Jangam s/o Vinyak" as shown in the example below:

The full command is add n/Jangam s/o Vinyak p/98765432 e/johnd@example.com a/John street, block 123, #01-01

image.png

This is problematic as there may be many clients with such names (due to it being a common name in Singapore) and the user will not be able to support these clients in the app.

nus-pe-bot commented 2 weeks ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Names not allowing for special characters limitation

Screenshot 2024-11-15 at 5.00.27 PM.png

Steps to replicate: add n/someone s/o else p/11111

While the UG states that the name field is only alphanumeric, this can prevent people from typing in the names of important clients which may have special characters, such as "s/o"


[original: nus-cs2103-AY2425S1/pe-interim#1189] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your bug report. Although we could allow “s/o” for users and it would give additional convenience, only allowing alphanumeric characters was the intended behaviour of PROperty.

PROperty is not intended to accept names with special characters, as stated numerous times in the UG. This could be subjected change in the future, and as such is not in the current scope.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Looking at the definition of the bug severity details, for Severity.Low, "A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only." This bug does not fit the bill of the details given. Property agents have a wide nationality of clients and I feel that having special characters is rather common in many cultures, hence it would at the very least be a occasional inconvenience to users even if they are able to use the app. This clearly fits "severity.Medium" better by the given definition in the textbook as "A flaw that causes occasional inconvenience to some users, but they can continue to use the product."