Closed xianglin1998 closed 11 months ago
You are welcome to add an entry to the CHANGELOG.md as well
Any reason to not just merge and get everyone testing these changes? It's anyway much better than current main.
Any reason to not just merge and get everyone testing these changes? It's anyway much better than current main.
Currently is disabled FAST_SIM, I'm worried you need it. Hahaha
Then I will open review and merge it for everyone to test this change!
@doegox merge now?
For the next step with FAST_SIM, it's probably better to implement a system of timers rather than delays, to get more stable timings. Currently we saw that FDT could vary quite a lot between runs.
@doegox merge now?
sure :)
For the next step with FAST_SIM, it's probably better to implement a system of timers rather than delays, to get more stable timings. Currently we saw that FDT could vary quite a lot between runs.
The NFC core comes with FDT controller, and we can use nrf_nfct_frame_delay_max_set
and nrf_nfct_frame_delay_min_set
functions for control
For the next step with FAST_SIM, it's probably better to implement a system of timers rather than delays, to get more stable timings. Currently we saw that FDT could vary quite a lot between runs.
The NFC core comes with FDT, and we can use
nrf_nfct_frame_delay_max_set
andnrf_nfct_frame_delay_min_set
functions for control
ha ok, nice!
For the next step with FAST_SIM, it's probably better to implement a system of timers rather than delays, to get more stable timings. Currently we saw that FDT could vary quite a lot between runs.
The NFC core comes with FDT, and we can use
nrf_nfct_frame_delay_max_set
andnrf_nfct_frame_delay_min_set
functions for controlha ok, nice!
Maybe issue110 need to reopen?
Forget it, wait until they have problems before reopening.
Can you help me write a change log? I want to go to bed now, haha. It's 4am Chinese time, I'm so sleepy haha. @doegox
ha no prob, I'll do :) Better to open a new issue if needed IMHO, 110 is crowded ;)
After nearly a week of testing and attempted repairs, MFC simulation is now compatible with most OEM readers and has solved the compatibility issues with mobile phones caused by fixing OEM compatibility issues. Note that this change temporarily disable FAST_SIM, this may not be the final fix we want. In theory, we should focus on FAST_SIM functionality is controllable, rather than simply disable.
The fixed of this big bug cannot do without the help of the community. Thanks to @doegox and @spp2000, as well as to many others in the community for their help.
Based on feedback from the current community, this fix can make their OEM card readers work perfectly. If you encounter issues that cannot work on OEM card readers, please try update to this firmware. And after the test, please feedback your result to this PR's comment section. Thank you very much.