Closed p-l- closed 6 months ago
You are welcome to add an entry to the CHANGELOG.md as well
Hello @xianglin1998 @doegox sorry for the ping. This PR has now been tested on both Windows (thanks @MrFlou) and Linux. Could you have a look? It really speeds up running hf mf elog --decrypt
.
Thanks! you know you don't need to rewrite and force-push commits, you can just add a commit in your branch and it'll be added to the existing PR.
Thanks @doegox. Actually I just amended the commit (hence the push force), I did not rewrite the PR!
You don't need to rewrite a PR. You don't need to amend a commit and force-push it. You can just push a new commit in your existing branch and it will automatically appear in the existing PR. That way, it's easier for reviewers to know what you changed after the reviewers comments. But if you amend the commit, then we've to read it all again and try to spot what you changed.
Not an issue here as it was just the changelog but this workflow may help in future commits. Thanks!
OK noted.
As a maintainer I use the link "force-pushed" in the message (@p-l- force-pushed the enh-hf-mf-elog-parallel branch from 9174b02 to cc674f1), but that's totally OK for me to add new commits, I'll do that for my future PRs to this project.
Thanks for the work & the super cool project BTW!
oh I didn't know that force-pushed link, thanks !
This PR will run as many
mfkey32v2
processes in parallel than the host CPUs count. It makes thehf mf elog --decrypt
command much faster.