Implement "hw slot info" to show which tag type loaded into all slots

RfidResearchGroup / ChameleonUltra

The new generation chameleon based on NRF52840 makes the performance of card emulation more stable. And gave the chameleon the ability to read, write, and decrypt cards.

https://chameleonultra.com

GNU General Public License v3.0

878 stars 147 forks source link

Implement "hw slot info" to show which tag type loaded into all slots #61

Closed Foxushka closed 1 year ago

doegox commented 1 year ago

Nice! Two suggestions:

implement -h, every command should support -h even if it does not take other parameters, see e.g. hw slot update -h
it would be nice to display nicknames with hw slot info when available.

BTW no need to force push changes, you can add commits to your branch and it will be taken into account in this PR

Foxushka commented 1 year ago

see e.g. hw slot update -h

Doesn't work, just executes command as usual

doegox commented 1 year ago

[USB] chameleon --> hw slot update -h
 - Update config and data from device memory to flash success.

and I wish hw slot info -h returns also one line of explanation rather than the slot info dumps

Foxushka commented 1 year ago

Check sources... https://github.com/RfidResearchGroup/ChameleonUltra/blob/fc0e016c045b136bd8444811befe68b9d8f9722f/software/script/chameleon_cli_unit.py#L960

doegox commented 1 year ago

Argh ok hw slot update was a bad example :D and I got tricked. IMHO every command should support -h and hw slot update should be fixed too. So a user who want to know about a command can always use -h without being afraid it will run immediately without knowing what it will do.

doegox commented 1 year ago

But we can think of a more global fix later. So I'll merge but if you could add nicknames later that would be great too!