Install phase misses platform define

codeexchange commented 4 years ago

brew install and flashing an PM3 Easy results in a non-booting PM3. I assume partially due to the recompile of sources caused by "make install" without platforms option:

$ export HOMEBREW_PROXMARK3_PLATFORM=PM3OTHER
$ brew install --verbose --HEAD rfidresearchgroup/proxmark3/proxmark3

[...]
cp -pR /private/tmp/d20200109-78036-sep31e/.coverity.conf.sample /private/tmp/proxmark3-20200109-78036-2c6dv4/.coverity.conf.sample
chmod -Rf +w /private/tmp/d20200109-78036-sep31e
==> make clean

===================================================================
Platform name:     Proxmark3 rdv4
PLATFORM:          PM3RDV4
Platform extras:   No extra selected
Included options:  SMARTCARD FLASH LF HITAG ISO15693 LEGICRF ISO14443b ISO14443a ICLASS FELICA NFCBARCODE HFSNIFF
Standalone mode:   LF_SAMYRUN
===================================================================
[*] MAKE client/clean
[!] Platform definitions changed, cleaning bootrom/armsrc/recovery first...
[*] MAKE bootrom/clean
[*] MAKE fpga_compress/clean
[*] MAKE armsrc/clean
[*] MAKE recovery/clean
[*] MAKE mfkey/clean
[*] MAKE nonce2key/clean
==> make all PLATFORM=PM3OTHER

===================================================================
Platform name:     Proxmark3 Generic target
PLATFORM:          PM3OTHER
Platform extras:   No extra selected
Included options:  LF HITAG ISO15693 LEGICRF ISO14443b ISO14443a ICLASS FELICA NFCBARCODE HFSNIFF
Standalone mode:   LF_SAMYRUN
===================================================================
[*] MAKE client/all
[-] CC proxmark3.c

[....]

[=] LD nonce2key
==> make install PREFIX=/usr/local/Cellar/proxmark3/HEAD-413af36

===================================================================
Platform name:     Proxmark3 rdv4
PLATFORM:          PM3RDV4
Platform extras:   No extra selected
Included options:  SMARTCARD FLASH LF HITAG ISO15693 LEGICRF ISO14443b ISO14443a ICLASS FELICA NFCBARCODE HFSNIFF
Standalone mode:   LF_SAMYRUN
===================================================================
[*] MAKE client/install
[@] Installing client to /usr/local/Cellar/proxmark3/HEAD-413af36...
[!] Platform definitions changed, cleaning bootrom/armsrc/recovery first...
[*] MAKE bootrom/install
[=] GEN version.c
[-] CC version.c
[-] CC ram-reset.s
[-] CC flash-reset.s
[-] CC ../common_arm/usb_cdc.c
[-] CC ../common_arm/clocks.c
[-] CC bootrom.c
[....]

make[1]: Nothing to be done for `all'.
[@] Installing common resources to /usr/local/Cellar/proxmark3/HEAD-413af36...
==> Install success!
==> The latest bootloader and firmware binaries are ready and waiting in the current homebrew Cellar within share/firmware.
==> Cleaning
==> Finishing up
ln -s ../Cellar/proxmark3/HEAD-413af36/bin/pm3 pm3

codeexchange commented 4 years ago

See PR #15

iceman1001 commented 4 years ago

Now that its merged, time to close?

RfidResearchGroup / homebrew-proxmark3

Install phase misses platform define #14