Closed iceman1001 closed 3 years ago
The building seems to be working nice. One thing with GH actions is that it doesn't color its output making it hard to find when there is a warning.
Potential shopstopers:
Since the conversion to cli-parser, I suspect minor textual errors in help text.
@merlokk will have a look at the Fido refactoring, he also mention there was some non-working hf mf autopwn
| hf mf nested
etc cli parsing.
@merlokk found the 14443-4 chaining isn't working. Which is a show stopper.
Chaining works, but @merlokk didn't get around to fix it all, he be AFK which will set this release on hold until he comes back.
alright, so much more was merged into the master... I guess one more round of testing it all again before a new release is needed.
But I am excited to see so much new stuff cipurse, desfire working.
New release pushed. closing
Checklist
make style
make clean; make client CC=clang CXX=clang++ LD=clang++
on recent Debian or Ubuntumymanualchecks.sh
mycppcheck.sh
no alarming warning?mymakeclang.sh
no alarming error/warning ?mystandalone_makes.sh
compile all standalone modes (linux only)OS compilation and tests