RfidResearchGroup / proxmark3

Iceman Fork - Proxmark3
http://www.icedev.se
GNU General Public License v3.0
3.96k stars 1.05k forks source link

Add Missing Loot Goblin Amiibo #1455

Closed maxpilar closed 3 years ago

maxpilar commented 3 years ago

Describe the bug The Amiibo to Eml script is missing the Loot Goblin identification.

To Reproduce Steps to reproduce the behavior:

  1. Run ./tools/pm3_amii_bin2eml.pl Loot\ Goblin.bin > goblin.eml Get back
    Character / info: 38 c0 00 00 03 91 16 02
    Game     :  38c
    Character:    0 --
    Variation:   00 --
    Type     :   00 Figure
    Amiibo   : 0391
    Series   :   16
    Last     :   02 (should be 02)

Expected behavior

Character / info: 38 c0 00 00 03 91 16 02
Game     :  38c Diablo 3
Character:    0 --
Variation:   00 --
Type     :   00 Figure
Amiibo   : 0391 Loot Goblin
Series   :   16 Diablo
Last     :   02 (should be 02)

Screenshots

Desktop (please complete the following information):

Additional context

--- tools/pm3_amii_bin2eml.org  2021-08-14 15:35:56.721914700 -0400
+++ tools/pm3_amii_bin2eml.pl   2021-08-14 15:45:14.955698500 -0400
@@ -156,6 +156,7 @@
 0x34c => "Street fighter",
 0x350 => "Monster Hunter",
 0x35c => "Shovel Knight",
+0x38c => "Diablo 3",
 );

 my %type = (
@@ -505,6 +506,7 @@
 0x035e => "BoxBoy!",
 0x0360 => "Fire Emblem",
 0x0361 => "Fire Emblem",
+0x0391 => "Loot Goblin",
 );

 my %amiiboseries = (
@@ -527,6 +529,7 @@
 0x10 => "BoxBoy!",
 0x11 => "???",
 0x12 => "Fire Emblem",
+0x16 => "Diablo",
 );

 use strict;
iceman1001 commented 3 years ago

... that script isn't maintained, so if you have something to add I suggest you make a PR