mfkey: add explicit -lpthread link directive to Makefile for linux builds

RfidResearchGroup / proxmark3

Iceman Fork - Proxmark3

http://www.icedev.se

GNU General Public License v3.0

3.86k stars 1.02k forks source link

mfkey: add explicit -lpthread link directive to Makefile for linux builds #2172

Closed ggallagh closed 9 months ago

ggallagh commented 10 months ago

nested_util.c requires pthread support. Prior to release 2.34 of glibc (around Aug 2021), libpthread was a separate library that needed to be explicitly supplied to the linker. Add the directive to make all linux builds happy.

github-actions[bot] commented 10 months ago

You are welcome to add an entry to the CHANGELOG.md as well

iceman1001 commented 10 months ago

Thanks for the PR!

Now, two PRs , two different solutions. Which to choose.
Someone mentioned that both works.

SKIPTHREAD seems to be the right path considering its purpose.

If noone else has any objections, I will close this PR and merge the other.

iceman1001 commented 9 months ago

Merged the other PR regarding this problem,.