RfidResearchGroup / proxmark3

Iceman Fork - Proxmark3
http://www.icedev.se
GNU General Public License v3.0
3.72k stars 998 forks source link

Fix Mifare Classic sim with interactive and reader attack mode never returning console #2198

Closed datatags closed 8 months ago

datatags commented 8 months ago

The help for hf mf sim says that if -i is passed, "Console will not be returned until simulation finishes or is aborted." However, when using interactive with the reader attack option (hf mf sim -ix), the console does not return when the simulation is finished or when the button is pressed.

This seems to be because in cmdhfmf.c, it continues waiting for more CMD_ACKs after processing the information from the device, while the device only sends CMD_ACK once (after the simulation is finished or the button is pressed.) Adding break after the readerAttack line seems to fix this, and doesn't seem to cause any other issues.

github-actions[bot] commented 8 months ago

You are welcome to add an entry to the CHANGELOG.md as well