search

RfidResearchGroup / proxmark3

Iceman Fork - Proxmark3
http://www.icedev.se
GNU General Public License v3.0
3.65k stars 981 forks source link

Add hint for iClass in `hf search` #2227

Closed bettse closed 6 months ago

bettse commented 6 months ago

It was:

[usb] pm3 --> hf search
 🕙  Searching for iCLASS / PicoPass tag...   
[+] iCLASS / Picopass CSN: CE F0 43 01 F7 FF 12 E0 

[+] Valid iCLASS tag / PicoPass tag found

And now it is 

[usb] pm3 --> hf search
 🕗  Searching for iCLASS / PicoPass tag...   
[+] iCLASS / Picopass CSN: CE F0 43 01 F7 FF 12 E0 

[+] Valid iCLASS tag / PicoPass tag found

[?] Hint: try `hf iclass` commands
github-actions[bot] commented 6 months ago

You are welcome to add an entry to the CHANGELOG.md as well

iceman1001 commented 6 months ago

This is divider...

either we have hints for all positive identifications, and should they come direct after each one or all hint goes in the bottom like the rest of the client does. or we don't have hints because its one type per identification compared with it is not "unknown" positives like for hf 14a info which can be a range of types.

hm....

Lets go with hints but I want them to be all in the end, like we do in other places in the client.

bettse commented 6 months ago

Lets go with hints but I want them to be all in the end, like we do in other places in the client.

I've not been in this area before, so I'm uncertain of the implication. Does that mean I should setup a variable that saves that it was iClass, and then create a conditional after all the checks that would output the hint?

iceman1001 commented 6 months ago

yes that is correct. And add hints for the other checks too, please.

bettse commented 6 months ago

And add hints for the other checks too, please.

That would be beyond the scope of what I'm looking to achieve: is that a requirement for the PR?

bettse commented 6 months ago

😮 I was working on the change to put the hint at the end, I just didn't want to introduce the other hints.

iceman1001 commented 6 months ago

yeah, I understand.